Consolidate auth testing#315
Merged
matthewmturner merged 2 commits intoApr 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/test.yml:274
- [nitpick] The job name 'test-auth' with the display name 'Extension / Auth-Basic-Bearer' is ambiguous since it now runs both Basic and Bearer auth tests. Consider renaming it to clearly reflect the consolidated nature of the tests, e.g., 'test-auth-consolidated'.
test-auth:
.github/workflows/test.yml:302
- The kill command may fail if 'server.pid' does not exist or is empty. Consider adding a check to ensure the file exists before attempting to kill the process.
- name: Kill FlightSQL Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.